Backwards compatibility issue

Open vladiulianbogdan opened this issue 7 years ago • 3 comments

Hi,

I've noticed that the NSLoggerData files generated before 10th December are not compatible anymore with newer versions of NSLogger. The logs will not appear in NSLogger if I try to open an .nslogger file.

In the commit with hash eef947f it seems like the LoggerConnection.m file was modified. In the initWithCoder method, the keys are different. That means file that were generated, for example, with key "message" and not compatible now with newer version because they are using key "_message".

Was this intended? If not, I have a fix this in a fork. Let me know if you want me to push a PR.

NSLogger is great! Thanks!

Feb 16 '19 18:02 vladiulianbogdan

I think this is a side effect of converting the viewer code from MRC to ARC! I didn't notice that we had backward compatibility issues, so yes please push your PR - thanks a lot!

Feb 16 '19 19:02 fpillet

Here it is: https://github.com/fpillet/NSLogger/pull/279.

Feb 17 '19 17:02 vladiulianbogdan

Can we close this one?

May 29 '19 04:05 c0diq