premailer-rails icon indicating copy to clipboard operation
premailer-rails copied to clipboard

Published 20 hours ago • verified publisher icon fphilipe

Looking for new maintainers?

Open caseyprovost opened this issue 2 years ago • 11 comments

The last commit was a couple of years ago and the PRs have been languishing for while. Are you looking for new maintainers by chance or just some approved collaborators to help merge PRs and update the gem?

PS: If either of these are true I think myself and/or my company may be able to help out

caseyprovost avatar Jun 17 '22 00:06 caseyprovost

I would love to help out as well, I've been rocking my own fork in production on the branch support-propshaft for months now

Intrepidd avatar Jun 30 '22 08:06 Intrepidd

@fphilipe ?

Faq avatar Jun 30 '22 19:06 Faq

I would love to help out as well, I've been rocking my own fork in production on the branch support-propshaft for months now

your branch just saved me a day of work, thanks :)

mopx avatar Aug 05 '22 17:08 mopx

I'd love to see this project get some more active maintenance as well!

tonydewan avatar Aug 23 '22 17:08 tonydewan

As project has long no activity from owner, then project can be considered as dead and should be looked for alternative gem. Best practice is to set project in archive mode.

Faq avatar Aug 23 '22 19:08 Faq

Since it seems like this project is dead, @Intrepidd would you consider forking and releasing a new gem from your branch? I also need propshaft support and am excited that you've already done the work!

sethherr avatar Sep 14 '22 16:09 sethherr

I will. Just need some time to fix the specs and have CI run on github actions

Intrepidd avatar Sep 15 '22 07:09 Intrepidd

In the meantime this works :

gem "premailer-rails", github: "Intrepidd/premailer-rails", branch: "support-propshaft"

Intrepidd avatar Sep 15 '22 07:09 Intrepidd

Here y'all go !

gem "premailer-rails-revived", "~> 1.12", require: "premailer/rails"

Intrepidd avatar Sep 15 '22 12:09 Intrepidd

@fphilipe would you consider adding people as co-maintainers and co-owners on rubygems? it'd be sad having a fork with a different name given the popularity of the gem itself :cry: (thank you @Intrepidd for your work!)

xdmx avatar Sep 16 '22 12:09 xdmx

Sorry everyone for being silent all the time. I'm not doing much with Ruby anymore and have a lot going on...

Having said that, I'll try to find some time to think about how best to proceed here by either

  • carving out some time to do it myself,
  • adding other contributors (some due diligence is needed as I don't know the people), or
  • archiving the project and allowing a fork to live on.

For those that reached out by email, this is my response for now 😊 Hope you understand.

fphilipe avatar Sep 16 '22 14:09 fphilipe

I've started making changes to the repo. My plan is to make a new release soon with these changes.

That'll include Webpacker and Propshaft support. Rails 7 support with Sprockets has always been there.

Thanks everyone 🙏

fphilipe avatar Oct 16 '22 20:10 fphilipe