Philipe Fatio

Results 36 comments of Philipe Fatio

Just checked, the example project is working. Can you provide more information?

Closing as this is possible as @markedmondson explained.

@orta no difference: https://github.com/fphilipe/pod_source_order_bug/commit/7197008eb41471b73bdc296e2f36e2949ed48ad9

I tried reproducing this in premailer 1.11.1 with nokogiri 1.10.5 but couldn't. The `>` character is not being encoded. I've found [this issue](https://github.com/sparklemotion/nokogiri/pull/1316) on Nokogiri that has been fixed. On...

Are you by chance using XHTML? Could you share the HTML of your email, at least the bare structure including the `` tag? I believe that Nokogiri is escaping the...

Dug a bit deeper. The culprit is the following line: https://github.com/premailer/premailer/blob/2ef4cdba9cd3e8bed7cc3749816b1f7ca00a0a6e/lib/premailer/adapter/nokogiri.rb#L137 Additionally, premailer is doing some suspicious manipulation of CDATA sections: https://github.com/premailer/premailer/blob/aae3be75a543e7292beadc43619ce882348845fd/lib/premailer/adapter/nokogiri.rb#L237-L244 Lastly, Nokogiri itself does some funny things to...

@amclin Can you elaborate why dropping Hpricot would be premature?

1.8.7 is retired and no longer receives any updates. So I'd say that dropping support for it is ok since most of the users moved on. Ruby 1.9 made working...

pinging involved people: @akzhan @alexdunae @ndbroadbent @grosser

@akzhan I have to agree with @grosser that creating a new gem called premailer2 is not good. I just don't see the advantages over keeping the name and just bumping...