Florian Maas

Results 48 comments of Florian Maas

Hey! Thanks for your contribution. I will check it out soon, I first need to sort out the bug in the CI/CD pipeline :)

Could you please add a functional test? i.e. - Add a directory with an example project structure in [`tests/data'](https://github.com/fpgmaas/deptry/tree/main/tests/data) - Add a corresponding test under [`tests/functional/cli'](https://github.com/fpgmaas/deptry/tree/main/tests/functional/cli)

Looks like there were a few formatting issues; https://github.com/fpgmaas/deptry/actions/runs/9409803890/job/25970899533?pr=724. You can resolve this by installing the pre-commit hooks locally with `poetry run pre-commit install`.

> Known issue: if the specified file to source dependencies from does not exist, this code will crash. @fpgmaas what is the best way to present this error to the...

> Is it possible to add any kind of tools (like release-please) to generate not only release, but also update CHANGELOG.md? That should be possible, but I have not worked...

@MrPowers Yes, I opened a PR for this! In order to get this to work, could you create a repository secret called `PYPI_TOKEN` on the repository, that is scoped to...

> What do you think about separating badges from the latest build / master and badges, related to the latest release? Good idea, especially since `main` and the latest release...

> @fpgmaas please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. > > ``` > @microsoft-github-policy-service agree [company="{your company}"] >...

Hi @AlonsoGuevara, did you maybe have the time to look into this? Could you approve the workflows to verify that the unit tests still pass? I understand that you may...

Looks great! Do you have an example of this being used in a PR somewhere? Would be great as an additional check that this works as expected. Maybe you can...