Filip Petkovski

Results 221 comments of Filip Petkovski

There was an LFX project that was a superset of this functionality: https://github.com/thanos-io/thanos/pull/5505 Maybe @saswatamcode or @matej-g have some information on how far that got and whether it makes sense...

I see that HA endpoints are out of scope of that proposal: https://github.com/thanos-io/thanos/pull/5505/files#diff-5dad1d444b473dcd0b72f4770b3ba03089499cfaf027205c83914f63124644e5R38. Are you looking to cover them in your work?

@SuperQ brought this feature up yesterday during contributor hours. Do we want to proceed with something like this until we have more extensive endpoint configuration? It would be great to...

I marked these flags as experimental, there could be some hidden dragons that we'll uncover over time.

Thanks for the heads up, I will take a look by tomorrow.

> But selector with role different from the job role can't be used to filter objects, but only determine whether to attach extra labels to targets. I think this is...

We run those tests as a library, but moving them to a separate package sounds like a good idea.

Thank you for the feedback. We wanted to experiment with the `xrate`/`xincrease` functions which have been discussed extensively in this issue: https://github.com/prometheus/prometheus/issues/3806. There are several forks out there that already...

Thanks for the feedback, and I am glad that Prometheus is willing to consider adding these functions under a feature flag. I will close this PR now and we will...

Thank you, much appreciated !