Frank Corso

Results 82 comments of Frank Corso

@danieliser Isn't this one already implemented? We save the last open for many of our triggers here, like in this one: https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/site/plugins/pum-triggers.js#L35 Or, is this referring to something different?

@danieliser Ah, that makes sense. So, my follow-up question would be: what is the use-case for this? When would someone need to be able to get the last open trigger...

@danieliser For that use case, do we just need this value stored within just the one page, maybe as a `data-*` value we check? Or, would we need to be...

@danieliser With the new block patterns, do you think we would utilize these INSTEAD of the premade layouts (#655) or in addition to?

@danieliser Reviewing the docs and it seems the templates take arrays whereas the block patterns take a string of HTML in block form. The content string would get messy if...

Okay, I'll close the #655 for now then. If we decide to use templates in the future for something specific, we can create an issue for that specific idea then.

@danieliser Keeping this in 1.15 for now as, depending on how we implement the popup wizard (#686), we might use these content groups as the "templates". At least in the...

@danieliser Should this be a dependency/sub-issue of #711 or should we remove this part from that issue? I definitely think we should highly-consider adding this to the scope of 1.11...

@danieliser Should we punt this one to 1.10?

@danieliser What would each of these options do? I'm assuming enabled/disabled is like the checkbox we have now but how would "Auto" differ from what we have currently? Would the...