Frank Corso

Results 82 comments of Frank Corso

@danieliser Updated the original message for this issue trying to recap most of the conversation, since we are slated to start implementing this in a little over 2 weeks. What...

@danieliser Okay, sounds good. Are there any other decisions or workflows that we need to think through before you start working on this in 2 weeks?

@danieliser Looking into this a bit. Since there are two ways to submit a GF form (PHP or AJAX) and we have different handlers for each, we will need slightly...

@danieliser Not sure what you mean. In both PHP and AJAX, the process is broken and no cookies are being set during either submission but for different reasons, as outlined...

@danieliser I don't know if the question mark on its own is obvious enough and it may not convey what it is enough. I like WP Rocket's strategy of doing...

@danieliser Do we already have a tooltip library/system in core or is there one within WP that you know of? jQuery UI has a tooltip component so we could do...

@danieliser So, we don't have anything in PM currently for tooltips, right? I did a search for within WordPress but I only found the [tooltip component](https://developer.wordpress.org/block-editor/components/tooltip/) in the block editor...

@danieliser Oh, if we are wanting to add a beacon, that would be what opens when you click on the `?` icons, right? So, if we end up doing that,...

@danieliser Hmmm...okay. I think I will clean up some of the links and then merge #928 for `1.15`. Then punt the `?`/tooltip discussion to `1.16` for when we start scoping...

@danieliser Our Gravity Forms integration also does not pass form instance to the form submission process: https://github.com/PopupMaker/Popup-Maker/blob/master/assets/js/src/integration/gravityforms.js#L20 Should we create another issue for adding instance identification to the Gravity Forms...