Frank Corso

Results 82 comments of Frank Corso

@danieliser The first thing for us to decide is the "where" for this in PM. I'm thinking it should go in the popup settings between "Targeting" and "Display". Would you...

@danieliser Been brainstorming a bit on this and mapping ideas out on the whiteboard. I think these should be two separate things. The event/action manager of #348 would be things...

@danieliser Yeah, maybe the CTA system handles its own system end-to-end and then the action manager would allow people to layer additional events on top of anything the CTA adds....

@danieliser I don't quite follow. Can you elaborate a little more on your question/thought?

@danieliser Oh, so you want to take a different approach than how we do it in Ahoy? I thought we were just porting over the ahoy system which would be...

Punted to 1.13 as discussed in Q3 check-in call.

@danieliser Hmmm.... lots to consider there. Since people are using this CTA inside of popups, slide-ins, bars, etc.. I would imagine needing more than one would be extremely rare. However....

@danieliser Okay, so we need: 1. A class/system that handles call-to-actions and outputs a button or necessary code, such as a form 2. A system that exposes that to the...

@danieliser Hmmm.... yeah, since we have the form integration system already built out and it will handle conversions already, you may be right that we do not need to add...

@danieliser For the styling: since we are expecting to use these outside of popups too, I don't think it makes sense to have any of the styling within the theme...