Keith Stevens

Results 89 comments of Keith Stevens

Sure! If the rest of the changes look good, prepare the PR, make sure the pre-commit checks all pass and then I'll take a look.

I recommend following the guidance in [this](https://timwise.co.uk/2019/10/14/merge-vs-rebase/#should-you-rebase) guide regarding pulling in changes from the main branch.

Great! I've done it before with nextJS so if you run into issues please let me know. For setting up the component stories, an idea would be to let us...

Question, is there any framework that renders the ui component to generate a screen shot image? Within Google we had some UI framework that would let us write some fake...

@martinnormark would you be interested in making an initial PR setting up either Nightwatch or Playright? They seem worth trying out and seeing if there's some hidden incompatibility.

I filed https://github.com/LAION-AI/Open-Assistant/issues/134. If you have a chance, can you copy paste the error you're seeing into the bug?

For now I'll assign this bug to you. No rush in addressing this issue now if the docker bug is blocking you.

One suggestion to investigate further is [Jest](https://jestjs.io/)

A request on however we setup testing, I think it'd be ideal for the React components to have their test code in the same directory as the component. [This example](https://github.com/SurfaceData/surface-redwood-template/tree/main/web/src/components/ui/SurfaceFooter)...

Yeah, Jest was a pain to setup with typescript. Some projects have done this for you and it's something I wish NextJS did as part of their starter package. Anyways,...