Milan Straka comments

Results 51 comments of


                                            Milan Straka

trafficstars

Add fromArrayMonolithic

There is no need to feel sorry -- the mistake of adding `fromArray` without discussing the semantics is mine as a maintainer, not yours :-) I understand you can feel...

A few more extractors for Data.Tree

Hello, thanks for spending time improving `containers`. Nevertheless, as noted in the README, please note that all API enhancements should be discussed on libraries@haskell mailing list. Please follow https://wiki.haskell.org/Library_submissions#Guide_to_proposers and...

A few more extractors for Data.Tree

Do not apologize, it is perfectly fine. The process of public discussion is quite unexpected (at least it was for me when I started with this). However, it allows people...

Consider adding Data.Sequence.{splitAtR, takeR, dropR}

Personally I am not sure whether these functions would benefit the API. Sure, I understand the consistency argument. On the other side, having a lot of functions can be a...

Consider adding Data.Sequence.{splitAtR, takeR, dropR}

@JLimperg It is my personal view that the functions you are suggesting are not worth adding -- but others may feel differently. Therefore do not hesitate to ask on libraries@haskell...

Export code necessary to make Arbitrary instances

All tests are compiled with `TESTING` macro, which exports constructors and several other methods, so I think the `Arbitrary` instances could be defined more efficiently -- it is just that...

Export code necessary to make Arbitrary instances

Oh, sorry, I did not get that. Reopening.

Type inference failed. This indicates an invalid graph that escaped type checking. Error message: INVALID_ARGUMENT

@gowthamkpr Well, the problem was first reported in tensorflow as https://github.com/tensorflow/tensorflow/issues/57052, but the guys there told the reporter to instead post an issue here. If you know any more details...

Type inference failed. This indicates an invalid graph that escaped type checking. Error message: INVALID_ARGUMENT

@gowthamkpr The issue was originally a TF issue, but we were redirected to post it here. If you know any more details (why it is a TF issue and not...

Memory leak activated when setting a seed in TensorFlow 2 (2.0 & 2.1) and using eager execution.

I believe this is caused by caching which `convert_to_eager_tensor` performs. Notably look at https://github.com/tensorflow/tensorflow/blob/7072568ed6b735e347fb87bc84a2b83daf806e3f/tensorflow/python/framework/constant_op.py#L68-L72 which mentions that some values can be cached. In the C++ code, https://github.com/tensorflow/tensorflow/blob/7072568ed6b735e347fb87bc84a2b83daf806e3f/tensorflow/python/eager/pywrap_tensor.cc#L307-L313 performs the caching...