feat(modify): new modifier `add_header`

Open msessa opened this issue 9 months ago • 4 comments

Partially addresses #158

Description

This PR adds a new modifier add_header which allows arbitrary headers to be added to a message in the pipeline.

Use Case

A practical use case is to inject the X-SES-FROM-ARN header before forwarding the message to AWS SES to control which identity will be used to verify the sender domain.

See reference here

Mar 02 '25 22:03 msessa

@foxcpp thanks for you review (and for creating maddy!)

I didn't realize the spec permitted fields appearing multiple times. I've adapted the code and tests for that

Mar 03 '25 12:03 msessa

btw I'm happy to also implement other variations of the modifier, eg: upsert_header remove_header if you think they could be useful

Mar 03 '25 12:03 msessa

@foxcpp any update on this PR?

Mar 26 '25 06:03 msessa

Interested in this feature as well. Hope it gets merged :)

Mar 26 '25 19:03 DEVisions