maddy icon indicating copy to clipboard operation
maddy copied to clipboard

feat: add smtp auth login support

Open buroa opened this issue 1 year ago • 7 comments

This let's providers like smtp.office365.com work.

buroa avatar Feb 23 '24 18:02 buroa

Extremely easy PR for you @foxcpp :)

buroa avatar Feb 25 '24 15:02 buroa

Needs corresponding documentation update

foxcpp avatar Feb 25 '24 15:02 foxcpp

@foxcpp Done!

buroa avatar Feb 25 '24 16:02 buroa

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 52.38%. Comparing base (1d6cd8c) to head (a87a9c0).

Files Patch % Lines
internal/target/smtp/sasl.go 0.00% 7 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #683   +/-   ##
=======================================
  Coverage   52.38%   52.38%           
=======================================
  Files         128      128           
  Lines       13382    13389    +7     
=======================================
+ Hits         7010     7014    +4     
- Misses       5707     5711    +4     
+ Partials      665      664    -1     
Flag Coverage Δ
integration 34.11% <0.00%> (-0.12%) :arrow_down:
unit 53.76% <0.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 25 '24 16:02 codecov-commenter

Let me add some tests as well @foxcpp.

buroa avatar Feb 25 '24 16:02 buroa

@foxcpp Ready for you.

buroa avatar Feb 29 '24 14:02 buroa

@foxcpp Can we get this merged?

buroa avatar Mar 19 '24 16:03 buroa

@foxcpp Ping

buroa avatar Aug 10 '24 14:08 buroa