Mark user shell as a path

[twiggler]

Currently, the UnixUserRecord encodes the user shell as a string. While this is safe from implicit path flavor conversions, making this field a path is semantically clearer.

Also check the other field types.

Related: https://github.com/fox-it/dissect.target/issues/891

[Peter-The-Great]

If the issue is still open, i might want to change it. Can do a quick fix for this. Then again the issue is a few months old still not sure if its still an issue?

[Peter-The-Great]

@twiggler If it is still open, maybe like a function that could dynamically edit the COMMON_UNIX_FIELDS. Something along the lines of:

override_fields(
        COMMON_UNIX_FIELDS,
        shell="string",
    ),

There could be a solution in there, making sure that you can always use the standard COMMON_UNIX_FIELDS, but also allowing them to be overwritten moredynamicly for each iteration of a differnt UnixUserRecord. Depending on if you need it. Or the more simpler option is to just:

("string", "shell"), --> ("path", "shell"),

[Schamper]

Nothing as complicated as that is required, just a change from ("string", "shell"), -> ("path", "shell"), and a sanity check if everything still works, maybe an added unit test.

[Peter-The-Great]

I guess. Then i will make those changes right now.