dissect.target icon indicating copy to clipboard operation
dissect.target copied to clipboard

Fix inconsistency of target.ips output

Open JSCU-CNI opened this issue 1 year ago • 4 comments

Fixes #877.

JSCU-CNI avatar Oct 01 '24 12:10 JSCU-CNI

Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints.

EinatFox avatar Oct 02 '24 08:10 EinatFox

Codecov Report

Attention: Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.01%. Comparing base (3b60c96) to head (db9e425). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/network.py 95.91% 2 Missing :warning:
dissect/target/tools/info.py 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
- Coverage   77.02%   77.01%   -0.01%     
==========================================
  Files         322      322              
  Lines       27575    27566       -9     
==========================================
- Hits        21239    21231       -8     
+ Misses       6336     6335       -1     
Flag Coverage Δ
unittests 77.01% <95.08%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 07 '24 15:10 codecov[bot]

Couldn't figure out how to properly modify a VirtualHive in a way the RegistryPlugin registers multiple ControlSets. Perhaps you know of a better way @Schamper?

JSCU-CNI avatar Oct 07 '24 17:10 JSCU-CNI

We can further simplify the general network plugin when https://github.com/fox-it/flow.record/pull/148 is merged.

JSCU-CNI avatar Oct 08 '24 14:10 JSCU-CNI

This is now ready for review.

JSCU-CNI avatar Oct 16 '24 11:10 JSCU-CNI