dissect.target
dissect.target copied to clipboard
Small log improvements
This PR addresses two small issues:
- The hash record modifier could generate a lot of warnings when combining the walkfs plugin with
--hashas a lot of files can be broken. this log is now demoted to INFO forFileNotFoundErrors as that exception is not really interesting in those instances. - When entering a child target using
--childrenor target-shell'senterthe path of said child was appended to the locations of where to look for targetcfg files. That obviously does not work as that path is virtual inside the main target. This is now fixed.
Fixes #880 and fixes #881.
Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.69%. Comparing base (
98527ae) to head (b08f4ae). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 76.68% 76.69%
=======================================
Files 316 316
Lines 27103 27109 +6
=======================================
+ Hits 20784 20790 +6
Misses 6319 6319
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 76.69% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.