dissect.target icon indicating copy to clipboard operation
dissect.target copied to clipboard

Add json output to target-query --list

Open JSCU-CNI opened this issue 1 year ago • 1 comments

This PR adds JSON output support to target-query --list using the --json flag. Fixes #887.

JSCU-CNI avatar Sep 04 '24 11:09 JSCU-CNI

Hi @JSCU-CNI , please open an issue and attache this PR so we can schedule a review into our sprints.

EinatFox avatar Oct 02 '24 09:10 EinatFox

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.87%. Comparing base (c39246d) to head (5b20057). Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   76.85%   76.87%   +0.01%     
==========================================
  Files         318      318              
  Lines       27231    27258      +27     
==========================================
+ Hits        20929    20955      +26     
- Misses       6302     6303       +1     
Flag Coverage Δ
unittests 76.87% <0.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 29 '24 14:10 codecov[bot]

This PR does not seem to be merged, but I can see a merge commit in main. What happened there? :sweat_smile:

JSCU-CNI avatar Oct 29 '24 16:10 JSCU-CNI

🤷 it's been merged twice now.

Schamper avatar Oct 29 '24 17:10 Schamper