dissect.target icon indicating copy to clipboard operation
dissect.target copied to clipboard

Add notice for PyPy users

Open cecinestpasunepipe opened this issue 1 year ago • 1 comments

(DIS-3295)

cecinestpasunepipe avatar Aug 20 '24 13:08 cecinestpasunepipe

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.51%. Comparing base (3822b47) to head (d8a712c). Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/tools/shell.py 80.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   75.51%   75.51%           
=======================================
  Files         305      305           
  Lines       26343    26348    +5     
=======================================
+ Hits        19893    19897    +4     
- Misses       6450     6451    +1     
Flag Coverage Δ
unittests 75.51% <80.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 20 '24 13:08 codecov[bot]

We wait until we they do a release? https://github.com/pypy/pypy/issues/5006

narimantos avatar Aug 20 '24 18:08 narimantos

We wait until we they do a release? pypy/pypy#5006

Yes, let's give them some time to respond before we implement the notice. If the manage to fix the issue we can probably do a version check as well, and urge our users to download the latest pypy.

cecinestpasunepipe avatar Aug 21 '24 07:08 cecinestpasunepipe