dissect.target icon indicating copy to clipboard operation
dissect.target copied to clipboard

Add computer SID for Windows systems

Open fox-evv opened this issue 1 year ago • 2 comments

This addition to the generic Windows plugin exports the machine and domain SIDs of the target. If the system is not joined to a domain, it uses only the/ SAM hive, but if the system is domain joined, it will all so use the Security Policy.

fox-evv avatar Aug 15 '24 14:08 fox-evv

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (35f64ff) to head (d73b0f5). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/generic.py 76.47% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   77.02%   77.02%   -0.01%     
==========================================
  Files         322      322              
  Lines       27566    27582      +16     
==========================================
+ Hits        21232    21244      +12     
- Misses       6334     6338       +4     
Flag Coverage Δ
unittests 77.02% <76.47%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 03 '24 07:09 codecov[bot]

@fox-evv I've suggested some changes and also added some test with this commit. One thing I could not verify myself is whether there can be multiple Machine / Domain SIDs. The initial implementation kind of seemed to suggest this. Do you encounter this scenario yourself? I left it out of this implementation because it seemed illogical to me.

Horofic avatar Sep 03 '24 08:09 Horofic