dissect.target icon indicating copy to clipboard operation
dissect.target copied to clipboard
verified publisher icon fox-it

Add output_def to PluginFunction

Open JSCU-CNI opened this issue 1 year ago • 1 comments

This PR adds the output_def attribute to the PluginFunction dataclass and populates it during runtime in find_plugin_functions. The output_def attribute should be filled with RecordDescriptor instances when the output_type is record. For further assumptions see test_find_plugin_function_record_def.

We use this attribute to discover all possible output field types of target-query in our (to be published) dissect-elastic tool. This tool facilitates in generating valid Elasticsearch field mapping objects.

JSCU-CNI avatar Jul 24 '24 11:07 JSCU-CNI

Thanks - this is also already covered by my own refactor of the plugin system internals, so don't be sad if this PR will be rejected 😉. I've been sick for a few days but I'm trying to get that wrapped up as quick as I can.

Schamper avatar Jul 24 '24 19:07 Schamper

Closing this in favor of https://github.com/fox-it/dissect.target/pull/763.

JSCU-CNI avatar Sep 25 '24 10:09 JSCU-CNI