fox-it
Add filesystem identifiers to walkfs
title basically. i did what i said i did. i also added the appropriate tests because apparently that is how you write code (BORING)
in my test files i never saw disk serial populated but since its a field i assume it is populated sometimes. hope i didnt spend a few hours on nothing.
i also made it so adding volume uuid's for new fs's very easy to do. theres like, a WHOLE function that does it, and you just need to add a new ELIF clause for your filesystem. your welcome, everyone who is gonna use this (probably only me 😢 )
@Schamper is there an update on this pr? no rush just wanna know whats happening 😄
@Schamper is there an update on this pr? no rush just wanna know whats happening 😄
I'm currently on leave for a little bit and this is too big a PR to review during toilet breaks, so I'll get to it when I'm back!
@Schamper is there an update on this pr? no rush just wanna know whats happening 😄
I'm currently on leave for a little bit and this is too big a PR to review during toilet breaks, so I'll get to it when I'm back!
alright, looking forward to it!
enjoy your leave (:
done and done (:
looking forward for the second CR!
(and even more for that eventual approve hehe)
i believe i covered all bases and then-some
by the way, this pr has evolved to a point where it makes my older pr, where i added UUID to mft parser, obsolete. id like to amend the code, i assume you'd prefer a new pr for it, but if you'd like it here just say. (should be a few lines at most)