Unify webserver log path retrieval
Related to #264.
The idea here is to use the ~~_log_paths()~~ _get_paths() function to retrieve the resolved log paths for the various webservers that we support. Future webservers should implement this function to automatically collect the resolved log files with Acquire. They also need to be added in the Acquire collection module.
Can you use
_get_pathsinstead? That's the currently defined standardized API for this:https://github.com/fox-it/dissect.target/blob/06990b845eec756e36f7704b1e42dbc73a0b04ef/dissect/target/plugin.py#L504
See #1082 for more details.
Fixed!
Codecov Report
:x: Patch coverage is 50.00000% with 17 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.99%. Comparing base (3c8e8f6) to head (99608e4).
:warning: Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
- Coverage 81.02% 80.99% -0.04%
==========================================
Files 376 376
Lines 33594 33627 +33
==========================================
+ Hits 27221 27237 +16
- Misses 6373 6390 +17
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 80.99% <50.00%> (-0.04%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
CodSpeed Performance Report
Merging #1287 will not alter performance
Comparing qmadev:fix/webserver_collection (99608e4) with main (3c8e8f6)
Summary
✅ 9 untouched
Fixed the linter, checks should be good now @twiggler