nake icon indicating copy to clipboard operation
nake copied to clipboard

Package 'nake' has an incorrect structure

Open arturtamborski opened this issue 5 years ago • 1 comments

Hi, I've installed nake with nimble and got this warning:

nimble install nake
    Prompt: No local packages.json found, download it from internet? [y/N]
    Answer: y
Downloading Official package list
    Success Package list downloaded.
Downloading https://github.com/fowlmouth/nake using git
   Warning: Package 'nake' has an incorrect structure. The top level of the package source directory should contain at most one module, named 'nake.nim', but a file named 'nakefile.nim' was found. This will be an error in the future.
      Hint: If this is the primary source file in the package, rename it to 'nake.nim'. If it's a source file required by the main module, or if it is one of several modules exposed by 'nake', then move it into a 'nakepkg/' subdirectory. If it's a test file or otherwise not required to build the the package 'nake.nim', prevent its installation by adding `skipFiles = @["nakefile.nim"]` to the .nimble file. See https://github.com/nim-lang/nimble#libraries for more info.
  Verifying dependencies for [email protected]
 Installing [email protected]
   Building nake/nake using c backend
   Success: nake installed successfully.

I think that the structure of nim programs changed in latest version.

Here's some version info:

nimble -v
nimble v0.10.2 compiled at 2019-08-29 08:31:13
nim -v
Nim Compiler Version 0.20.2 [Linux: amd64]
Compiled at 2019-07-17
Copyright (c) 2006-2019 by Andreas Rumpf

Happy to send fix if you think that it's worth fixing.

arturtamborski avatar Aug 29 '19 08:08 arturtamborski

This warning is still present though it has not turned in to an error.

Although it may also pose a problem for projects using Nake downstream. They will have to have a nakefile.nim which Nimble will also complain about. Not sure what to do about this one.

IcedQuinn avatar Aug 06 '22 01:08 IcedQuinn