Matt Fowles Kulukundis
Matt Fowles Kulukundis
We have changed our major version policy as part of https://developers.google.com/protocol-buffers/docs/news/2022-05-06#versioning so 21.3 is correct. The binary itself is still reporting 3.21.3, which we may need to look into.
Just leave this one. We are talking about how to resolve it internally
We will need you to sign the CLA before we can review this change.
Just a warning that the best person to review this is out for a bit, so you should expect silence for at least a week
This is likely because the builders use the methods from the Java API directly (which are the ones marked deprecated). We probably need suppresession annotations.
I am deeply confused by this error. Tracing through the various static asserts it seems like the only way this can fail is if `sizeof(void*) == 8` but `alignof(void*) ==...
I need you to make a tiny program with the same build flags and output `sizeof(void*)` and `alignof(void*)`
just to clarify this is a **32 bit** windows build, yes?
I doubt we will have time to pursue this optimization any time soon. If you are feeling ambitious, you could try to implement it, but I do not think this...
I am kind a shooting blind here, but can you check if add PROTOC_EXPORT to https://github.com/protocolbuffers/protobuf/blob/701dd83594c5d979481bc36ac58efea670a929ba/src/google/protobuf/compiler/cpp/helpers.h#L637 fixes this for you?