Craig E. Shea

Results 143 comments of Craig E. Shea

The idea of this issue is excellent. I have a use-case where I have another module that is a dependency of the module I'm writing and which I'm including in...

I failed to see that there is already defined a `-Description` parameter on the `Task` function. I wonder how people use that parameter? Is it displayed, if used? (Rhetorical question--I...

One could argue that this change should be hoisted up to `PSDepend\PSDependScripts\PSGalleryModule.ps1`. However, one counter-argument to that argument is that potentially _any_ PSDependScript passing data to `Import-PSDependModule` could be susceptible...

@johlju, Yes, you are correct, but that's because PowerShell has _no idea_ about pre-release versions. The `-RequiredVersion` parameter of `Import-Module` is a `System.Version`, which is a Microsoft-proprietary version number format...

Exactly. So, because PSDepend was passing the _full_ SemVer version string as the `-RequiredVersion` parameter to `Import-Module`, this was breaking the import of pre-release modules. Looking at PowerShell Core, I...

Per your other comment regarding `Save-Package`, I got this, too. And PSDepend cannot help with this. You are correct. Some modules have binary dependencies. For example, if you write a...

I took a cursory glance at the code, and it doesn't even appear that the certificate is being looked for, contrary to the README! Mind you, perhaps it's looked for...

OK, perusing the code some more, I don't see _anywhere_ where an attempt to use a certificate located at `$(Agent.ToolsDirectory)/_jf/security/certs` is made. Maybe `jf.exe` does this "automagically", that's my next...

Finally found the docs for usage of a private CA certificate in a non-obvious location. Again, a "deep link" would've been nice.

Looking at the code for the JF DotNet task, for pushing packages to Artifactory, it calls a function named `performDotNetNugetPush`, which further calls into the JF CLI via a function...