frontend-perf icon indicating copy to clipboard operation
frontend-perf copied to clipboard

Published 20 hours ago • verified publisher icon fourkitchens

Upgrade to [email protected] for Node v4 compatibility

Open DavidHughes opened this issue 9 years ago • 1 comments

Hi,

Just setting up before DrupalCon Barcelona, brew install node is installing the newly launched node v4.1.0. Attempting to run gulp bs leaves me with the issue raised on gulp-sass's repo -> https://github.com/dlmanning/gulp-sass/issues/340

After installing [email protected], the local server seems to be running as usual. The ghooks pre-push task did fail the tests, however. I'm not sure if that is intended or not, so disabled the hook locally so I could make this PR.

DavidHughes avatar Sep 19 '15 11:09 DavidHughes

Thanks for the PR! However, I'm wary of doing this directly before the training. I tested using node 4.1 and got a lot of errors.

I think instead of upgrading to the latest and greatest, I suppose the smarter thing to do would be to advise folks to use nvm, similar to rbenv for ruby. This ensures that we're using a compatible version of node without having to do dependency whack-a-mole just before the training. Plus, in that issue the maintainer indicated that it's a node-sass issue, not gulp sass.

Regarding the failed tests, yes it's intentional. We will fix the tests as part of the training :+1:

rupl avatar Sep 20 '15 16:09 rupl