emulsify-gulp
emulsify-gulp copied to clipboard
Updating browsersync config “domain” to use proxy and host
Even though config.browserSync.domain,
was mapped to proxy, It might be confusing to use "domain" as a local browserSync setting as there is actually a real setting for domain in browserSync. I also discovered that it works best if host
is used in tandem with proxy
.
However, this could be an edge case. I'm using Docksal so it was crucial for host and proxy to be used together for browserSync to work on the Docksal domain. Note the browserSync setting for "domain" (AKA socket
) actually has to do with using in tandem for socket.io
. https://browsersync.io/docs/options#option-socket
I also added in some more standard options that are nice to have within the proxy if statement which I also updated to check for the two conditions needed.
If this pull request is not acceptable, I'm fine with just running a patch automatically after npm install.
@evanmwillhite Thanks for all the detailed information! I don't have a lot of free time right now to go back and work on this so I am not sure when I would have time at the moment.
@danny-englander That's OK, thanks for responding. If someone has time on our end, we can just open up a separate PR. Thanks again!