Seth Miller
Seth Miller
I like the idea of having a shame list, but I also like the idea of having actional best practices too to help those learn and get off the list.
I just came across this! Sorry if this is an older issue, but I have some code to reproduce: ```python from colour import Color start = Color("#da0000") print("start HSL: "...
FYI that is a "forward slash" not a dash "-"
After reading through this, it seems the issue isn't with consuming the entire body, starlette actually will pump that async generator and save it to the request for subsequent requests:...
This PR seems like it might fix this actually: https://github.com/encode/starlette/pull/944
Hey @maresb, @liormizr, Could you guys summarize your final thoughts into a quick list or something? I can try and work on a PR for this if you're interested. I'd...
Do you mean `str(S3Path.from_uri("s3://bucket/sample.csv")) == "s3://bucket/sample.csv"` ? I will admit I find the additional step of using `from_uri()` instead of just the constructor kind of annoying in practice. ¯\\\_(ツ)\_/¯
That's really inefficient because it reads the entire file into memory. Using streams like boto3's upload methods are much better. I think Path's .rename interface is the most intuitive but...
Thanks for following up. Yeah I don't think it's inherently an issue with S3Path, it's more of an issue with how Pathlib handles `self.rename(other)`. It doesn't check what the "other"...
Does it suck up an entire file list before globbing? This is from `pathlib.py` in the python stdlib: ```python def _select_from(self, parent_path, is_dir, exists, scandir): try: with scandir(parent_path) as scandir_it:...