pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Allow GrantItem REs to assign a badge value to granted items

Open Cerapter opened this issue 2 years ago • 4 comments

https://user-images.githubusercontent.com/43446478/198371192-b2a6fc47-c853-4220-9acb-64334920bda2.mp4

This PR changes the behaviour of GrantItem REs so that they can now set the granted item's badge value if applicable (right now, only Effects and Conditions).

If "Reevaluate on Update" is ticked on, the granted item's badge value will update if something changes on the actor / item.

Cerapter avatar Oct 27 '22 18:10 Cerapter

This is planned, but I'd like to approach it in a broader way to anticipate other alterations to an item.

stwlam avatar Oct 27 '22 18:10 stwlam

If I recall, there's a standing uncertainty over whether item alterations should be part of the GrantItem itself or defined in subclasses. Which at this point honestly, I'm fine with either if defining the item type in GrantItem is untenable or unwieldy. This is actually one of those "hard problems" you've stumbled into, one that is actually the reason we've been building out this functionality.

CarlosFdez avatar Oct 27 '22 21:10 CarlosFdez

So should this PR be just closed then?

Cerapter avatar Oct 27 '22 22:10 Cerapter

There was a bit of a discussion. Shark, what's your opinion on an "overrides" object with a "type" field that restricts the type of item being overriden, that explicitly handles specific overrides for the item? So if the type is "effect" it would allow certain specific overrides (and if the grant type doesn't match, fail validation).

CarlosFdez avatar Oct 28 '22 06:10 CarlosFdez

Taking a less stapled-on approach to this

stwlam avatar Nov 17 '22 02:11 stwlam