pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Rules elements on read-only items don't allow close

Open steev42 opened this issue 2 years ago • 3 comments

image

After expanding a rules element for an item from a compendium that isn't opening for editing, both the Close and Apply buttons are deactivated. Close (without save) should be allowed to return to full Rules Element list.

steev42 avatar Sep 19 '22 21:09 steev42

Need to make it not openable in the first place

stwlam avatar Sep 20 '22 01:09 stwlam

@stwlam If you've selected the option to view them, I think it's fine to open them. It can help to learn how they work (which is what I was doing with this one).

steev42 avatar Sep 20 '22 03:09 steev42

I can see an argument for it being in a read only mode. If its trivial to make that change I'll try it, but if its tricky I'll make it not openable in the first place.

CarlosFdez avatar Sep 20 '22 05:09 CarlosFdez

https://github.com/foundryvtt/pf2e/pull/4519 I believe this fixes it?

KSops avatar Nov 04 '22 19:11 KSops

Looks like you are correct @KSops. I'll allow someone else to close, but I'm satisfied that it works properly now.

steev42 avatar Nov 04 '22 21:11 steev42