pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Published 20 hours ago • verified publisher icon foundryvtt

Predicate Crafting Entry Batch Sizes

Open ebuckle opened this issue 2 years ago • 8 comments

Alternate to: https://github.com/foundryvtt/pf2e/pull/3353

Resolves #1903

As title, instead of having fieldDiscovery being a trait, instead use a predicate fieldDiscoveryItems in the same way as craftableItems, allowing the problem of munitions crafter to be more cleanly solved.

The only pain with this is the field discovery ae-likes, since they're adding a RawPredicate postDerived and have to be validated in the crafting entry. Thoughts?

As I stated in the other PR, this still leaves a problem of Precious Munitions but that needs a wider fix to actually allow materials to be applied to ammunition.

ebuckle avatar Sep 05 '22 21:09 ebuckle

Rather than refactoring this, we should remove fieldDiscovery (and anything else alchemist-specific) from the rule element.

stwlam avatar Sep 05 '22 21:09 stwlam

So yeah, my thinking to make this even more generic was to have an array of of predicate/batch sizes with each formula using the greatest valid batch size or the default.

ebuckle avatar Sep 05 '22 21:09 ebuckle

Crafting entries now have no mention of field discoveries, Alchemist/Munition crafter entries now have all the required predicate knowledge by default

ebuckle avatar Sep 09 '22 10:09 ebuckle

Updated batch size field to use new predicates

ebuckle avatar Sep 28 '22 13:09 ebuckle

Hi, so what is the status on this? #3510 was closed in favor of #3353, which in turn was closed in favor of this pr, but now this one is stale for a month.?

RobertBeilich avatar Oct 25 '22 01:10 RobertBeilich

At a glance, all the predicates are malformed.

stwlam avatar Oct 25 '22 01:10 stwlam

Hi, so what is the status on this? #3510 was closed in favor of #3353, which in turn was closed in favor of this pr, but now this one is stale for a month.?

Thanks for bumping it up, after a year it gets boring for me to patch it up locally after every version :smile:

Far2Casual avatar Oct 25 '22 09:10 Far2Casual

Did another pass on the predicates to match how they work now and updated branch

ebuckle avatar Oct 26 '22 12:10 ebuckle

Good for another review.

I'll make a seperate contribution to the wiki detailing the re when I get some time

ebuckle avatar Oct 31 '22 18:10 ebuckle

Is there anything else missing for this to be merged?

ebuckle avatar Nov 08 '22 12:11 ebuckle

Is there anything else missing for this to be merged?

@stwlam, any comment on this?

RobertBeilich avatar Nov 19 '22 14:11 RobertBeilich

@stwlam I'm sad to see this dropped. Ammunition Crafting (lvl 1 feat for Gunslinger) is still broken and requires me to patch my game locally every version for about a year and a half :(

Far2Casual avatar May 23 '23 08:05 Far2Casual