pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

NPC Ability checks mislabel fortune rolls as misfortune

Open ChiefMilesEdgeworth opened this issue 2 years ago • 7 comments

Version: 3.13.5.16 No modules loaded.

When rolling a basic ability check from an NPC sheet (Strength, Dex, etc.) and clicking "Fortune", the chat card with the roll instead says "Misfortune". The roll is treated as a fortune effect though, still keeping the higher roll.

2022-08-17-084115_294x175_scrot

ChiefMilesEdgeworth avatar Aug 17 '22 12:08 ChiefMilesEdgeworth

This is legacy, unmaintained code. Rolling skills is not a thing in the PF2e ruleset; I'm surprised this even survived. Skills used per PF2e rules (say, acrobatics) use the new mode, which works correctly. This is either going to be a won't fix or deprecated entirely.

TMunsie avatar Aug 17 '22 17:08 TMunsie

Ok. I'm new to Pathfinder, so I'm adjusting still. Where would you roll a skill that an NPC doesn't have (like say Athletics)?

ChiefMilesEdgeworth avatar Aug 17 '22 17:08 ChiefMilesEdgeworth

That's 100% up to the GM as NPC builds don't follow PC building rules. Normally you wouldn't have an NPC roll a skill like that. (Ask yourself why would an NPC attempt to do something they have no idea how to do.)

Do you have a specific example? I'll add that the only contested check in all of PF2e is initiative, so an NPC isn't ever forced to roll against a PCs roll except in that circumstance.

TMunsie avatar Aug 17 '22 17:08 TMunsie

I'm thinking about actions like Trip/Grab. As long as the base stats are there it's probably not a big deal, since I could just roll a d20 if the situation calls for it like you said.

ChiefMilesEdgeworth avatar Aug 17 '22 17:08 ChiefMilesEdgeworth

You might want to read a bit about NPCs in the GMG. Unless you're playing an NPC as an idiot, if they aren't trained they're asking for trouble if they try to do combat manoeuvres against a party. You can follow untrained rules if you like for PCs, but it is still going to be a GM adjudication.

TMunsie avatar Aug 17 '22 17:08 TMunsie

Ok, thanks so much! It probably would be good to deprecate rolling raw stats on NPC sheets then. I could make a PR if need be.

ChiefMilesEdgeworth avatar Aug 17 '22 17:08 ChiefMilesEdgeworth

Ability checks exist on NPCs because they use their ability modifier for any untrained skill check. It's a longstanding piece of technical debt that we're hoping to clean up soonish.

stwlam avatar Aug 17 '22 17:08 stwlam

Turns out to be an easy fix to the bug itself, even though this code looks like it should all just die

asuffield avatar Apr 08 '23 03:04 asuffield