pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Add siege weapon actor type

Open surged20 opened this issue 3 years ago • 5 comments

Adds a siege weapon actor and a sheet modeled off of the vehicle sheet style. Icon is derived from https://game-icons.net/1x1/heavenly-dog/catapult.html

surged20 avatar Jul 27 '22 19:07 surged20

This isn't something we can consider for this release, and next major release will be for V10--which will require a full rewrite of the PR.

stwlam avatar Jul 27 '22 19:07 stwlam

This isn't something we can consider for this release, and next major release will be for V10--which will require a full rewrite of the PR.

I figured that might be the case for this type of enhancement given the focus on v10. I'll plan to update the PR to the v10 release when available.

surged20 avatar Jul 27 '22 19:07 surged20

OK, sounds good. Thank you for the contribution, though, and sorry about the timing!

stwlam avatar Jul 27 '22 19:07 stwlam

I'm resolving a UI issue and will fix the eslint fallout along with that.

surged20 avatar Sep 08 '22 16:09 surged20

This should pass CI now if you can approve the workflow.

surged20 avatar Sep 12 '22 14:09 surged20

The only concern I have about merging this is that I'm now not happy with the data model of storing mounted siege weapon stats as actions. I started working on converting this to have a fixed aim, load, launch set of data which I think is better for future system automation. e.g. launch would have traits, damage, target type, and save DC properties. In the current model it's just an unstructured wall of text in the Launch action. It's not a huge amount of data entry, but it would all need to change for this data model update.

surged20 avatar Jan 26 '23 22:01 surged20