pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Published 20 hours ago • verified publisher icon foundryvtt

Localize NPC resistance exceptions

Open MSAbaddon opened this issue 2 years ago • 2 comments

MSAbaddon avatar Jul 26 '22 22:07 MSAbaddon

Not crazy about this one. We shouldn't be exposing localization keys in sheet inputs.

stwlam avatar Aug 24 '22 07:08 stwlam

Not crazy about this one. We shouldn't be exposing localization keys in sheet inputs.

This is rather in order to localize the resistance exceptions within resistance rule elements. Should the localization happen in the rule element instead?

MSAbaddon avatar Aug 24 '22 07:08 MSAbaddon

@stwlam Just realized I still have this pull request open. I switched localization to the rule element. This way the localization key isn't exposed to the sheet input.

MSAbaddon avatar Sep 25 '22 19:09 MSAbaddon