Deleting item from compendium or items directory should show broken link in formula

[cswendrowski]

trafficstars

In GitLab by @mkahvi on Nov 7, 2021, 09:43

Repro:

1. Create item in items directory or compendium
2. Drag that to formulas tab on the character
3. Delete the item created in step 1 (e.g. as part of moving it from items directory to compendium).
4. Re-open sheet and note that there's now no reference at all to the item, not even a broken link.

This is especially bad if you trust the system to keep your formula book intact.

I'd hope at least the item name is kept and the item is displayed as having broken link. As it is, it just vanishes when items are re-organized outside of the character sheet.

[cswendrowski]

In GitLab by @stwlam on Nov 8, 2021, 23:41

This is intended behavior. You can only trust your formula book to the extent that you can trust your GM to not delete the things you want to make.

[cswendrowski]

In GitLab by @stwlam on Nov 9, 2021, 24:14

Leaving this open for @ebuckle to review

[cswendrowski]

In GitLab by @ebuckle on Nov 9, 2021, 05:44

Agree that this is intended. Formulas only store the reference ID for the item they craft, no additional information. If the item they link to no longer exists, we'd be unable to give meaningful information about which formula is missing and why, only that one is gone.

It would be best to be careful when deleting world objects, as Shark said.

[cswendrowski]

In GitLab by @mkahvi on Nov 9, 2021, 12:57

Including the name of the missing formula would be greatly meaningful in my opinion, especially when the formula book doesn't actually let you see any other information to begin with.

All that requires is to store the name as it was when added alongside the uuid.