pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Display synthetic Note for `AdjustDegreeOfSuccess` when there’s no DC

Open simonward opened this issue 1 year ago • 8 comments

simonward avatar Sep 29 '24 17:09 simonward

What information do you envision that isn't in the adjustment tooltip?

stwlam avatar Oct 07 '24 16:10 stwlam

There isn't an adjustment tooltip when there's no DC.

Here's an example with Valeros rolling a Will save vs fear.

  1. In the first result, there's a DC so the adjustment tooltip is available.
  2. In the second, there is no DC, and thus no outcome to adjust. A fresh copy of Valeros has a Note RE that displays. However, there's a move towards removing the Notes.
  3. The third example is Valeros with a refreshed copy of Bravery saving vs fear - there is no reminder to check the Bravery ability.

~~I recognize the predicate makes it tricky, so I'm not sure it's practical.~~ Actually, I don't think that changes things.

Screen Shot 2024-10-07 at 10 25 34 AM

simonward avatar Oct 07 '24 17:10 simonward

What information would the "synthetic" note contain? We can't reliably turn a predicate into a meaningful sentence or two.

stwlam avatar Oct 07 '24 19:10 stwlam

True enough, but I could imagine it displaying the item name and text if the predicate is met?

simonward avatar Oct 07 '24 19:10 simonward

The full item description?

stwlam avatar Oct 07 '24 19:10 stwlam

I didn't like the removal of the notes, and in practice its led to more instances of "remember I have juggernaut" for me in cases where I was asked to do an improv save, but I was under the impression that I was one of the only ones who even had that opinion so I avoided speaking up past the once.

We can't really do much better than listing Bravery: One Degree Higher though, or adding a description field to item alteration itself. Item description is probably going to be too long.

EDIT: We could maybe do the entire item description if we collapse/tooltip it maybe.

CarlosFdez avatar Oct 07 '24 20:10 CarlosFdez

Yeah, the entire description might be a bit long, although it would only displayed if the DC is missing. I like the “Bravery: One Degree Higher”.

We would probably also need a suppressNote field in case a custom Note is required.

simonward avatar Oct 07 '24 21:10 simonward

I remembered we will want proper item description tooltips eventually, so this might be another use case for it.

CarlosFdez avatar Oct 07 '24 21:10 CarlosFdez