pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Mid-encounter actor level changes don't recalculate encounter metrics (threat, xp)

Open shemetz opened this issue 1 year ago • 1 comments

Applying Elite or Weak to NPCs in an encounter doesn't alter the calculated threat. Those level adjustments are correctly taken into account in the calculateXP function parameters -- the problem is that clicking the Elite/Weak buttons on NPC sheets doesn't trigger recalculation of this number.

This is a problem because as a GM I sometimes wish to create improvised combat encounters and fine-tune them to be at the right threat level. This means that after adding a few enemies I try to set some of them as Elite or Weak and see how it affects the threat ranking. With this bug, I can't get immediate feedback on this, I have to e.g. remove and add them to combat again.

shemetz avatar Sep 09 '24 09:09 shemetz

I imagine that the right solution to this problem would be: hook into updateActor, condition on actors that are combatants, condition on updates that change actor level. when this happens, recalculate combat XP (or clone+recreate combat object, however the system does it normally)

shemetz avatar Sep 09 '24 09:09 shemetz