pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Automate increase and decrease to item repair

Open jesuisfrog opened this issue 1 year ago • 2 comments

Added automation for the repair macro.

It will now check the new "repairValue" data point under actor.system.crafting to allow for customization of the amount of HP that can be repaired with the macro. The default is set to 5 as per the base repair action.

Crafter's Eyepiece has been updated with two new rules to add to repairValue and to add a flavor note about the updated repair numbers.

This should close #10958

(Apologies for the two closed PRs, I had some issues with them but it's all resolved now)

jesuisfrog avatar Aug 07 '24 21:08 jesuisfrog

This looks good, but would you mind making it crafting.repair an object with a lone value field? Then we won't have regret later if there is other repair-related data we want to track.

stwlam avatar Sep 02 '24 16:09 stwlam

@stwlam Made the requested change!

jesuisfrog avatar Sep 02 '24 18:09 jesuisfrog

Can you foresee other values being inside system.crafting.repair? I'm wondering if we can't replace system.crafting.repair.value with system.crafting.repair.success and system.crafting.repair.criticalSuccess. Because AELikes set the crafting proficiency though, perhaps this can't be done very cleanly without resorting to system.crafting.repair.success.base and system.crafting.repair.success.perLevel. I'm wondering if this might be a thing better attempted once we have proper skill tracking.

CarlosFdez avatar Jan 05 '25 06:01 CarlosFdez