pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

PC2 alchemist no worky how PC2 say it do

Open stwlam opened this issue 1 year ago • 11 comments

future issue preemption

stwlam avatar Jul 30 '24 22:07 stwlam

This affects:

  • [ ] Alchemist
  • [ ] Alchemist Dedication
  • [ ] Herbalist Dedication
  • [ ] Poisoner Dedication
  • [ ] apply item bonus directly on Versatile Vials (#16201)
  • [x] Update Alchemist traits (#16243 )

ammalagonc avatar Jul 31 '24 22:07 ammalagonc

  • [ ] Investigator (Alchemical Sciences)

MrVauxs avatar Aug 01 '24 16:08 MrVauxs

  • [ ] Gunslinger Munitions Crafter

simonward avatar Aug 01 '24 20:08 simonward

No versatile vial bombs seem to be in the system

jesuisfrog avatar Aug 01 '24 23:08 jesuisfrog

As far as I can tell, daily crafting with batches is no longer a thing. one way to fix would be to change the numeric value here: https://github.com/foundryvtt/pf2e/blob/65aaad5927d9d659c1ab8818968fd038681cd0e9/src/module/rules/rule-element/crafting/entry.ts#L51 alternative would be a rewrite or allow overriding via rule element

JonWaterfall avatar Aug 08 '24 19:08 JonWaterfall

Shouldn't this be more of a "data gap" or "bug" than a "feature request"

aremedis avatar Aug 09 '24 15:08 aremedis

I'm going to try and tackle this one, if there is a comprehensive list of the feature gap, please do share to make it easier.

jesuisfrog avatar Aug 22 '24 21:08 jesuisfrog

Nevermind, work is being done on the crafting overhaul and PRs won't be accepted for fixes at the moment.

jesuisfrog avatar Aug 24 '24 01:08 jesuisfrog

image

Not sure if part of this issue or a new issue, but: the Additive trait has not been updated, even though feats using it have been. Instead of being "Additive 2" for example, it should just say "Additive", and its new description should be put in place.

shemetz avatar Aug 26 '24 06:08 shemetz

Typo in REs on the current build for Efficient Alchemy (Paragon) lvl 20 Feat. image

ottyn avatar Oct 08 '24 18:10 ottyn

Is there any update on this issue ?

David-Moreland avatar Oct 30 '24 11:10 David-Moreland

Is there any update on this issue ?

seems like it keeps getting pushed down the list for things that were released after PC2 /cry

thejoester avatar Nov 13 '24 15:11 thejoester

It as been almost 6 month since PC2 has been released, I think that before going on implementing new books, devs should focus on making sure everything already their is implemented correctly.

rorp24 avatar Nov 19 '24 21:11 rorp24

It as been almost 6 month since PC2 has been released, I think that before going on implementing new books, devs should focus on making sure everything already their is implemented correctly.

Dude, these are volunteers making this for free. All of whom with day jobs, families, hobbies. Entitlement doesn't tend to look great in these situations. It's coming, it's being worked on, it is discussed near daily in the discord server if you want updates.

samgrieve avatar Nov 19 '24 21:11 samgrieve

Also just to add, if you desperately want things now it's pretty workable via a couple of rule effects and a macro for Quick Alchemy. But honestly, just let the team do their thing.

samgrieve avatar Nov 19 '24 21:11 samgrieve

It as been almost 6 month since PC2 has been released, I think that before going on implementing new books, devs should focus on making sure everything already their is implemented correctly.

It would be pretty funny if I told everyone else, who can't contribute to the crafting stuff at this time because its mostly a code change, to stop and do nothing while I continue to churn away at it bit by bit. Like, imagine if the new premium modules couldn't release, and people had to wait at least 2 months to play whatever AP just released? Think of the chaos!

Sure, it'd probably release about 2-3 weeks faster than currently projected because I wouldn't have to pause for major updates, but people wouldn't be able to play any of the new stuff for months!

Personally I'd prefer if Paizo slowed down a bit.

CarlosFdez avatar Nov 19 '24 23:11 CarlosFdez

All good Supe! Been watching the commits you have been putting in on the crafting system and it's coming along great. Most of us understand it's a huge project to rewrite it all and really appreciate all the work you are doing!

ottyn avatar Nov 19 '24 23:11 ottyn

It as been almost 6 month since PC2 has been released, I think that before going on implementing new books, devs should focus on making sure everything already their is implemented correctly.

Dude, these are volunteers making this for free. All of whom with day jobs, families, hobbies. Entitlement doesn't tend to look great in these situations. It's coming, it's being worked on, it is discussed near daily in the discord server if you want updates.

We are all appreciative of the awesome work being done. That doesn’t mean we can’t question or express our frustrations on why non CORE products that were released months later are done before the alchemist.

thejoester avatar Nov 20 '24 03:11 thejoester

It as been almost 6 month since PC2 has been released, I think that before going on implementing new books, devs should focus on making sure everything already their is implemented correctly.

Dude, these are volunteers making this for free. All of whom with day jobs, families, hobbies. Entitlement doesn't tend to look great in these situations. It's coming, it's being worked on, it is discussed near daily in the discord server if you want updates.

We are all appreciative of the awesome work being done. That doesn’t mean we can’t question or express our frustrations on why non CORE products that were released months later are done before the alchemist.

Lets ignore the monetary reason which is that there are actual products being sold using the "non CORE products", and that you're suggesting we roadblock premium modules from releasing.

Its because data entry is done by people manually inputting data, and alchemist requires programming work. The people working on the "non-core" stuff are not able to work on alchemist. That's me working on it, and I'm not full time. Nor have I been commissioned to do it and I have a day job. Different groups of people. What you're doing is amounting to asking chefs to fix the delivery app.

It doesn't help that the current existing crafting implementation is built out of toothpicks and bubblegum and is taking a lot of time to fix.

CarlosFdez avatar Nov 20 '24 03:11 CarlosFdez

That’s a perfectly reasonable answer, and it makes sense. I am just saying to those answering with nasty responses (not you) attacking those who ask and calling them entitled and such - it’s not an unfair question to wonder. Now we know, at least those in this thread.

thejoester avatar Nov 20 '24 03:11 thejoester

No problem. For context, I think its people who are watching the pull requests and seeing I've been slaving away at it for a few months. Next release at least has advanced alchemy working for the archetypes, but quick alchemy is going to take a bit more work.

This won't go out for a while yet but this is my current progress:

image

CarlosFdez avatar Nov 20 '24 03:11 CarlosFdez

@CarlosFdez Hey, just wanted to tell that advanced alchemy seems to work as intended on archetype (except for the fact that to make the same item multiple times you have to drag and drop it multiple times, which is annoying). Can't wait to have it on alchemist.

rorp24 avatar Nov 21 '24 16:11 rorp24

While I think that the UX issue will be mostly resolved if we have drag/drop functional, quantity increasing/decreasing is only for infused reagents currently and I'd like to have it functional for the rest. I'll try to think of something.

CarlosFdez avatar Nov 22 '24 04:11 CarlosFdez

@CarlosFdez IDK if this is a you problem, but even though advanced alchemy is working, munitions crafting doesn't seem to be? Like, bullets are crafted as single items instead of in units of 10.

Peach774 avatar Nov 28 '24 01:11 Peach774

@CarlosFdez IDK if this is a you problem, but even though advanced alchemy is working, munitions crafting doesn't seem to be? Like, bullets are crafted as single items instead of in units of 10.

That was a bug. Should be fixed by https://github.com/foundryvtt/pf2e/pull/17516

CarlosFdez avatar Nov 28 '24 02:11 CarlosFdez

Alchemist now worky like PC2 say it do

CarlosFdez avatar Dec 16 '24 22:12 CarlosFdez