update rule element for Sparkling Targe to account for other traits

[ammalagonc]

Closes #15304 Closes #15305

[iBoMbY]

This doesn't solve the issue https://github.com/foundryvtt/pf2e/issues/15304 though

[iBoMbY]

Also Sparkling Targe does work against all magical effects, not just item effects. The first commit was correct imho.

[stwlam]

Also Sparkling Targe does work against all magical effects, not just item effects. The first commit was correct imho.

"item" is in a foundry sense rather than a pathfinder one.

[iBoMbY]

I see a different problem here though, I did try it with "item:trait:magical" and it seems always be set/true if the shield itself is magical, even though the item/effect it defends against isn't magical. I guess in this case there would be no way to differentiate between both sides.

Edit: At least for the ItemAlteration when it runs for the shield itself.