foundryvtt
[Improvement] Fullfill Roll requests from chat with User Main Actor when Party Token is selected
First things first: Foundry v11.315, PF2 5.15.1, verified in a empty PF2 test world without active Modules (Active Module count: 0!)
When you request rolls from players from chat (for example with the system included "Generate Check Prompt" Macro) the system seem to use the following options to determine which Actor is used to roll the Check Prompt for the player: If you have selected a token, the stats from that token are used to roll. If you have not selected a token on the actual scene the stats from the "Main Character" selected in the User configuration seem to be used. This, up to this point, seem to make total sense for me.
If you use the Party Token and give your users access to that token (for example: let the user move around the token on a map to indicate where the Party is located) and the Party Token is selected the Check Prompt Rolls does not work out since the system seem not to be able to do the roll with that special actor (which, absolutely, make sense as this is a special actor). On the UI side nothing seem to happen, on the Javascript Console you get the message "PF2e System | Skip rolling unknown statistic athletics".
My wish for improvement: Could you include a "special" rule for the selected party actor token (since Party Actor is anyway build-in special this should be possible to simple hard code) to act like "if you have the party token selected act like no token is selected and just roll with the main character of the user".
This seem to make totally sense for me to behave that way since, meanwhile, it will get a little bit annoying to remind your players continously with "you must deselect the party token first before you try to role that check, that's the reason why nothing happens".
(And yes, I know I could unpack the party token or directly place only user tokens or don't give users access to that token and only move it by myself. But I just want let my users control the party token and they should still be able to roll checks uncomplicated :) ).
(And in general just default to User's Character when no token selected and user has Ownership of multiple actors)
(And in general just default to User's Character when no token selected and user has Ownership of multiple actors)
Just to mention: Did not test this case, so no idea how the system behaves in that case.
This occurs because of Kingmaker. I'll try to find a way to fulfill this without breaking kingmaker. EDIT: Fixing this one is incredibly risky due to the code's fragility. I will wait till after V12 for this, given its not a major bug.
This occurs because of Kingmaker. I'll try to find a way to fulfill this without breaking kingmaker. EDIT: Fixing this one is incredibly risky due to the code's fragility. I will wait till after V12 for this, given its not a major bug.
Maybe this is at least possible to look at the Kingmaker Campaign Feature setting in a way like "ok if the Kingmaker feature is not activated then.." to decide to handle the Party Token special. That make it work for most games then (but yes, as a developer myself I understand the inner struggle that the system starts to behave differently depending on a setting that the user will never connect to that one Kingmaker checkbox in the settings is awful, too).
And v12 is totally fine, as said would be a nice improvement 🙂
I will have to rework the actor selection code to handle this scenario is the thing. And its kinda scary to do something like that when we're wrapping up the final releases for v11 (I want the final v11 release to be as stable as possible).
What I'll likely end up doing is filtering out all tokens that are a party that do not own that statistic (or if the statistic is flat). And if this occurs and the list is now empty, fall back to the assigned character.