pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

FlatModifier RE should fall back to an item's slug before using a sluggified label

Open Cuingamehtar opened this issue 11 months ago • 1 comments

The RE ignores the item's slug and uses its name instead.

This causes AdjustModifier to stop working with this modifier if the name is different. This causes issues for localization.

Self-contained example : Intimidating Prowess on a character with +5 strength and mastery in Intimidation

When the feat has the default name (Intimidating Prowess), it works as expected. But if the name is changed (a simple typo is enough), then AdjustModifier RE can't find the mod, and the +2 bonus to Intimidation is not applied.

Cuingamehtar avatar Mar 14 '24 15:03 Cuingamehtar

If there are multiple FlatModifiers on the same item, they will all get the same slug if they fall back to the item's slug. They can be given slugs to avoid fallback. But a problem appears if this might not be the only instance of the rule on the actor, such as an effect with a choiceset applies multiple times with different choices chosen. The value of the choice set can be placed into the label, and thence to the slug, to make them unique. But the choiceset value can not be placed directly into the item slug.

xyzzy42 avatar Apr 06 '24 17:04 xyzzy42