Feature Request: `GrantItem` RE feat location

[Nhaaro]

I came across this while making a Class Archetype taking inspiration from the Way of the Spellshot, looking through the discord server it seems I'm not the only one

The system already has a location field for feats, but, as of now, updating it rather cumbersome and not very user-friendly, having the field in the Rule Element I think would be a new addition instead of having to go to the console and updating it with fromUuidSync('...').update({"system.location": "..."})

This also opens up to less redundancy/duplicates in feats, in my case I wanted to give Weapon Specialization a few levels early, but for that I had to create a new duplicate just for this change

I'd gladly contribute this feature, just need some indications on where to look in the codebase and possible ramifications

[stwlam]

I'm not sure I follow what is being requested here. You can change the level a class feature is granted from a class item.

[Nhaaro]

this is more about which section it appear in rather than the level the item actually has

btw, this is the other person that had a similar use case https://discord.com/channels/880968862240239708/880969241552113695/1188545293285851218

Case 1 - Lower the level access of a feat

in this case, Weapon Specialization is a level 7 feat that Summoners get at level 13

when I add a GrantItem Rule Element it gets the same nesting behaviour as other GrantItems

rather than it being added to the list like other Class Features

Case 2 - Automate Dedication Feat

in this case, we want the Dedication Feat to appear in the Class Feats category

however when we create the items and add the Rule Element it appears as a descendant of the granter item

this does not happen with the SpellShot Dedication

to do that we need to run an update from the console fromUuidSync('...').update({"system.location": "class-2"})

[CarlosFdez]

If you're asking for GrantItem to grant disconnected feature that would then go to an automatically assigned location (with the potential to override the level), that kinda terrifies me. That can create a situation where an archetype grants a class feature, it goes into class features, then it'd get deleted when the class changes (or stick around with no indication of where it came from).

[Nhaaro]

that's a really good point, I was thinking of it working the same way that Way of the Spellshot does, so only exposing system.location so it can be set from the Rule Element would suffice.

for reference, Spellshot Dedication automatically moves to class-2 whenever it is granted by GrantItem (unless that slot is already taken); but it's still connected to the item that grant it for all purposes of onDeleteActions and the like.

I tested a few cases for Way of the Spellshot and Spellshot Dedication and it was never left behind after Way of the Spellshot was removed, not even "onDeleteActions": { "grantee": "detach" } altered this behaviour.

[TikaelSol]

It may make some sense for class archetypes to get some kind of better handling, where they auto fill the dedication feat at level 2 (though some give you the benefit of the dedication at level 1 I believe?)

Right now they are kind of hard to grok how to use them for new users, though we could probably fix that with some improvements to how the archetype journals are written for them.