pf2e
pf2e copied to clipboard
Add support for specifying which weapon to use for a combat maneuver
As part of the changes, support for adding a passthrough object to the roll check helper function has also been implemented.
To avoid needing a CombatManeuverActionUseOptions and CombatManeuverActionPassthroughOptions and maintaining duplicates of every property (source and transformed), could we not resolve the item in the actions themselves? I think a resolveItem() helper that does that (which accepts null/undefined and returns null) in the disarm/trip/shove might not be out of line?
To avoid needing a CombatManeuverActionUseOptions and CombatManeuverActionPassthroughOptions and maintaining duplicates of every property (source and transformed), could we not resolve the item in the actions themselves? I think a resolveItem() helper that does that (which accepts null/undefined and returns null) in the disarm/trip/shove might not be out of line?
My plan is actually to take this a notch further by having some methods like getAdditionalModifiers(...)
and the like to keep it more general. But it's going to be a bigger refactoring to get rid of the old ActionMacroHelpers.simpleRollActionCheck()
.