pf2e icon indicating copy to clipboard operation
pf2e copied to clipboard

Allows sending items to any container from `carryType` menu

Open reonZ opened this issue 1 year ago • 9 comments

Foundry_Virtual_Tabletop_PFQ5BNtPgY

Lists all the containers inside the carryType menu and allow any non-container item to be moved to them.

I arbitrary set the max width of the menu in case of extra long container name.

reonZ avatar Jan 17 '24 14:01 reonZ

My vote here is "hell no", but if Supe is at least lukewarm I'll defer to him.

stwlam avatar Jan 17 '24 18:01 stwlam

figured !

reonZ avatar Jan 17 '24 22:01 reonZ

Perhaps with a divider

CarlosFdez avatar Jan 17 '24 22:01 CarlosFdez

I still need to resurrect the context menu branch, but a potential alternative is to do Send to X buttons on the right click menu instead.

CarlosFdez avatar Jan 19 '24 03:01 CarlosFdez

Conflicts!

stwlam avatar Jan 26 '24 11:01 stwlam

I can't figure out why the tooltip centers itself based on the max possible content instead of the outer part of the tooltip, this makes it move to the left with long container names.

image

When i do the same in my module, i don't have this issue, but i couldn't make head or tail as to why this would happen here.

reonZ avatar Jan 26 '24 14:01 reonZ

text overflow ellipses might be your friend here, though you'll need a bit for that to work out.

Also, this may be extra work, but I think this should probably pop open a dialog to allow splitting the stack?

CarlosFdez avatar Jan 26 '24 21:01 CarlosFdez

text overflow ellipses might be your friend here, though you'll need a bit for that to work out.

i use it (you can see the ellipses in the screenshot), i have pretty much the same setting for my module and the tooltip does center properly

if you want a popup, i think the approach should be different and use another button instead of using the carry-type one

reonZ avatar Jan 26 '24 22:01 reonZ

By a popup, I mean the same thing that occurs when you drag to or from a loot sheet, where it asks for a quantity. It'd only show if quantity > 1.

CarlosFdez avatar Jan 26 '24 22:01 CarlosFdez

I'll close this since it hasn't been updated for a while, but the past few months and some conversations in the development help channel has convinced me that stowing functionality that allows you to split the stack is very likely where many people would like to go with this, if anyone wants to pursue that route.

Thanks for making this PR though.

CarlosFdez avatar Jun 11 '24 00:06 CarlosFdez