foundryvtt-starfinder icon indicating copy to clipboard operation
foundryvtt-starfinder copied to clipboard

Modifiers not applied if Primary Damage Section is unchecked when rolling damage

Open ian612 opened this issue 6 months ago • 4 comments

Describe the bug When rolling damage with a weapon that has additional damage sections, if the one marked as the primary damage section is unchecked then no modifiers are applied to the roll. This prevents alternate damage formulas (such as from entropic strike/shot) from replacing weapon damage properly.

To Reproduce Choose a character (I used Velloro L8). Add a damage section to a weapon (Semi-auto pistol, advanced), give it a damage type and formula of 1d3. Add the Sickened condition to the actor. Roll damage with the weapon. In the dialog box, uncheck the weapon's main damage section, and check the non-primary damage section. Click Normal to roll damage. The damage on the weapon will only show 1d3 damage, it will not include any modifier from Sickened.

Expected behavior The damage should have modifiers applied to it

Screenshots image

Technical details (please complete the following information):

  • OS: Windows 11
  • Browser: Firefox
  • Foundry Version: 11.331
  • SFRPG Version: 0.27.0 (dev)

Additional context This may also appear on earlier system versions, but it definitely appears on development, at least

ian612 avatar Aug 17 '24 14:08 ian612