starknet-foundry icon indicating copy to clipboard operation
starknet-foundry copied to clipboard

Feat/change add profile to update profile

Open raizo07 opened this issue 11 months ago • 6 comments

Closes #1914

Introduced changes

-Changed all instances of --add-profile to --update-profile -Simplified logic for addition of profile -Simplified logic for updating/override of profile

Checklist

  • [x] Linked relevant issue
  • [x] Updated relevant documentation
  • [ ] Added relevant tests
  • [x] Performed self-review of the code
  • [x] Added changes to CHANGELOG.md

raizo07 avatar Mar 22 '24 13:03 raizo07

Hi @raizo07 , there seems to be some problems with CI failing (cast tests), please fix them and then re-request a review. thanks!

THenry14 avatar Mar 27 '24 09:03 THenry14

Hi @raizo07 , Hope everything's going well! Just wanted to touch base regarding this PR. If you need any input, run into questions, or would like to discuss anything, feel free to reach out. We're here to support you if you run on any blockers :) cheers!

THenry14 avatar Apr 05 '24 11:04 THenry14

Hello @THenry14 what platform can I reach out to you on?

raizo07 avatar Apr 05 '24 12:04 raizo07

Hello @THenry14 what platform can I reach out to you on?

Hi, we can discuss any problems related to this PR in here, under the PR :+1:

THenry14 avatar Apr 08 '24 11:04 THenry14

Hello @THenry14 what platform can I reach out to you on?

Hi, we can discuss any problems related to this PR in here, under the PR 👍

Hi @raizo07 , friendly reminder - any progress on this?

THenry14 avatar Apr 19 '24 09:04 THenry14

Hello @THenry14 what platform can I reach out to you on?

Hi, we can discuss any problems related to this PR in here, under the PR 👍

Hi @raizo07 , friendly reminder - any progress on this?

Yes, i'm currently working on resolving the test issues, I should have some updates soon.

raizo07 avatar Apr 20 '24 04:04 raizo07

Closing due to lack of activity

Arcticae avatar Jun 11 '24 14:06 Arcticae