foundry icon indicating copy to clipboard operation
foundry copied to clipboard

`forge install smartcontractkit/ccip@contracts-ccip/v1.2.1` fails with "remote: Not Found" due to tag name containing "/"

Open DJViau opened this issue 1 year ago • 6 comments

Component

Forge

Have you ensured that all of these are up to date?

  • [X] Foundry
  • [X] Foundryup

What version of Foundry are you on?

forge 0.2.0 (2fc85cb 2023-10-05T00:18:04.223871000Z)

What command(s) is the bug in?

forge

Operating System

macOS (Apple Silicon)

Describe the bug

forge install transmissions11/solmate@branch/name/with-slashes fails but forge install transmissions11/solmate@branch-name-with-dashes works.

The first outputs the erroneous message:

Installing with-slashes in /Users/user/path/project/lib/with-slashes (url: Some("https://github.com/transmissions11/solmate@branch/name/with-slashes"), tag: None)
...

The second outputs the expected message:

Installing solmate in /Users/user/path/project/lib/solmate (url: Some("https://github.com/transmissions11/solmate"), tag: Some("branch-name-with-dashes"))
...

I'm inferring that forge is splitting on / naively, which is messing up accessing the repo name and the tag.

Edit:

This was clarified here: https://github.com/foundry-rs/foundry/issues/5996#issuecomment-2010030371

DJViau avatar Oct 05 '23 19:10 DJViau