foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Feat/consolidate cast convert

Open dipanshuhappy opened this issue 1 month ago • 2 comments

Motivation

Resolves #12500

Solution

Create a new file convert.rs which encapsulates all the sub commands mentioned.

PR Checklist

NOTE: This does break existing cli commands related to conversation. Refer to the issue to know more about the cli commands that will break.

  • [ ] Added Tests
  • [x] Added Documentation
  • [x] Breaking changes

dipanshuhappy avatar Nov 22 '25 14:11 dipanshuhappy

thank you will need to fix tests to move forward

Updated

dipanshuhappy avatar Nov 29 '25 09:11 dipanshuhappy

@dipanshuhappy appreciate the work ser

0xClandestine avatar Dec 01 '25 21:12 0xClandestine

I don't think we should merge this as is as it is breaking. What I would suggest is shimming the existing commands to call convert <...> internally and displaying a "This command is deprecated and may be removed in the future, please use cast convert <...> instead" message.

I realize this ends up making the code a bit messy again, but I'd much prefer this to us pushing a breaking change for a very common set of commands in a non-major bump

Understood... Updating to that ASAP.

dipanshuhappy avatar Dec 10 '25 15:12 dipanshuhappy