forge-std icon indicating copy to clipboard operation
forge-std copied to clipboard
verified publisher icon foundry-rs

ABIEncoderV2 deprecation

Open nikola-matic opened this issue 2 months ago • 4 comments

We (Solidity) are working on introducing a new experimental pipeline (CLI/JSON) behind which we would hide all of our current experimental features (ABIEncderV2 included, along with all other features invoked with pragma experimental). We also intend to deprecate and remove quite a few of these (not ABIEncoderV2 of course).

Unfortunately, some of the external projects that we use for testing to make sure that the compiler is compatible, have either direct usages of pragma experimental ABIEncoderV2;, or via dependencies (forge-std in this case). This doesn't leave us with many options - either we exclude ABIEncoderV2 from the experimental pipeline, which doesn't really do anything except for delaying the inevitable - or, we can kindly ask you to fix the issue at the source - https://github.com/search?q=repo%3Afoundry-rs%2Fforge-std%20ABIEncoderV2%3B&type=code.

@PaulRBerg I see you've meddled in this one as well - and prb-math is one of the failures. Could you take a look please? Replace with pragma abicoder v2 should be sufficient.

Here's the PR for our experimental flag/option in case you want to see the CI failures yourselves.

nikola-matic avatar Dec 08 '25 09:12 nikola-matic

Hi @nikola-matic, I am looking at the CI logs for prb-math, and they seem to be NOT failing because of prb-math's own code but because it pulls in forge-std as a dependency. So, I guess if it gets fixed in the forge-std, it should work for prb-math too.

smol-ninja avatar Dec 08 '25 12:12 smol-ninja

Hi @nikola-matic, I am looking at the CI logs for prb-math, and they seem to be NOT failing because of prb-math's own code but because it pulls in forge-std as a dependency. So, I guess if it gets fixed in the forge-std, it should work for prb-math too.

Hi @smol-ninja, thanks for taking a look. Yeah, it's a forge-std dependency failure - this is the correct repository for this issue, right?

nikola-matic avatar Dec 08 '25 12:12 nikola-matic

this is the correct repository for this issue, right

Yes. I will let the Foundry team reply to your issue, I was replying on behalf of Paul re. prb-math.

smol-ninja avatar Dec 08 '25 12:12 smol-ninja

I think this ties into: https://github.com/foundry-rs/forge-std/issues/764

zerosnacks avatar Dec 08 '25 14:12 zerosnacks