forge-std icon indicating copy to clipboard operation
forge-std copied to clipboard

Via-IR Compilation tests do not provide confident results

Open sambacha opened this issue 2 years ago • 1 comments

https://github.com/foundry-rs/forge-std/blob/1d9650e951204a0ddce9ff89c32f1997984cef4d/.github/workflows/ci.yml#L87

The forge version being used is inconsistent, let alone not having different yul.OptimizerSteps defined per compilation.

Time series data should be persisted at least to offer some historical comparison at the most naive level.

sambacha avatar Sep 03 '23 16:09 sambacha

Can you expand on the suggestions here? I don't quite follow.

The via-ir checks in CI are sanity checks to avoid introducing changes that cause via-ir compilation time to blow up, ref https://github.com/foundry-rs/forge-std/issues/321 and https://github.com/foundry-rs/forge-std/issues/207, which was the motivation for introducing them

mds1 avatar Sep 05 '23 20:09 mds1

Can you expand on the suggestions here? I don't quite follow.

The via-ir checks in CI are sanity checks to avoid introducing changes that cause via-ir compilation time to blow up, ref #321 and #207, which was the motivation for introducing them

This is closed by https://github.com/foundry-rs/forge-std/pull/526 and https://github.com/foundry-rs/forge-std/pull/550

sambacha avatar May 30 '24 19:05 sambacha